Broken image links in Koha manual
Hi On 20 February 2017 I have written the following about Koha 16.11 and the same is still true for Koha 17.05: Koha contains a context-sensitive help function in the staff client at the upper right corner which will open a new window. At the end of every such window there is a link to the manual included. But clicking it will lead to http://manual.koha-community.org/16.11/en/ resp. http://manual.koha-community.org/17.05/en/ In both these manuals THE LINKS TO EVERY SINGLE IMAGE ARE BROKEN. I think if there is a beautiful new manual like https://koha-community.org/manual/17.05/html/ it should be the one that Koha links to (instead of the old manuals with the broken image links). Tell me if I can help correcting this. Best wishes: Michael -- Geschäftsführer · Diplombibliothekar BBS, Informatiker eidg. Fachausweis Admin Kuhn GmbH · Pappelstrasse 20 · 4123 Allschwil · Schweiz T 0041 (0)61 261 55 61 · E mik@adminkuhn.ch · W www.adminkuhn.ch
Hi Michael I fixed these links https://koha-community.org/documentation/ In February, is the link broken in Koha itself? Chris On 19/06/17 10:34, Michael Kuhn wrote:
Hi
On 20 February 2017 I have written the following about Koha 16.11 and the same is still true for Koha 17.05:
Koha contains a context-sensitive help function in the staff client at the upper right corner which will open a new window. At the end of every such window there is a link to the manual included. But clicking it will lead to http://manual.koha-community.org/16.11/en/ resp. http://manual.koha-community.org/17.05/en/
In both these manuals THE LINKS TO EVERY SINGLE IMAGE ARE BROKEN.
I think if there is a beautiful new manual like https://koha-community.org/manual/17.05/html/ it should be the one that Koha links to (instead of the old manuals with the broken image links).
Tell me if I can help correcting this.
Best wishes: Michael
Hi Cormack
I fixed these links
I'm not talking about https://koha-community.org/documentation/ - everything is OK there.
In February, is the link broken in Koha itself?
I'm talking (again) about the links from the Koha staff client that direct to the Koha manual. For example you will find one such link via my demo installation. (user: demo / password: demo) http://koha.adminkuhn.ch:8080/cgi-bin/koha/help.pl At the bottom of this help page there is a link to the manual with all broken image links: http://manual.koha-community.org/17.05/en/ Sorry if my English is not clear enough. Best wishes: Michael -- Geschäftsführer · Diplombibliothekar BBS, Informatiker eidg. Fachausweis Admin Kuhn GmbH · Pappelstrasse 20 · 4123 Allschwil · Schweiz T 0041 (0)61 261 55 61 · E mik@adminkuhn.ch · W www.adminkuhn.ch
On 19/06/17 10:34, Michael Kuhn wrote:
Hi
On 20 February 2017 I have written the following about Koha 16.11 and the same is still true for Koha 17.05:
Koha contains a context-sensitive help function in the staff client at the upper right corner which will open a new window. At the end of every such window there is a link to the manual included. But clicking it will lead to http://manual.koha-community.org/16.11/en/ resp. http://manual.koha-community.org/17.05/en/
In both these manuals THE LINKS TO EVERY SINGLE IMAGE ARE BROKEN.
I think if there is a beautiful new manual like https://koha-community.org/manual/17.05/html/ it should be the one that Koha links to (instead of the old manuals with the broken image links).
Tell me if I can help correcting this.
Best wishes: Michael
There was a bug submitted for this and I submitted a patch. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817 On Sun, Jun 18, 2017 at 5:11 PM, Michael Kuhn <mik@adminkuhn.ch> wrote:
Hi Cormack
I fixed these links
I'm not talking about https://koha-community.org/documentation/ - everything is OK there.
In February, is the link broken in Koha itself?
I'm talking (again) about the links from the Koha staff client that direct to the Koha manual. For example you will find one such link via my demo installation. (user: demo / password: demo)
http://koha.adminkuhn.ch:8080/cgi-bin/koha/help.pl
At the bottom of this help page there is a link to the manual with all broken image links:
http://manual.koha-community.org/17.05/en/
Sorry if my English is not clear enough.
Best wishes: Michael -- Geschäftsführer · Diplombibliothekar BBS, Informatiker eidg. Fachausweis Admin Kuhn GmbH · Pappelstrasse 20 · 4123 Allschwil · Schweiz T 0041 (0)61 261 55 61 · E mik@adminkuhn.ch · W www.adminkuhn.ch
On 19/06/17 10:34, Michael Kuhn wrote:
Hi
On 20 February 2017 I have written the following about Koha 16.11 and the same is still true for Koha 17.05:
Koha contains a context-sensitive help function in the staff client at the upper right corner which will open a new window. At the end of every such window there is a link to the manual included. But clicking it will lead to http://manual.koha-community.org/16.11/en/ resp. http://manual.koha-community.org/17.05/en/
In both these manuals THE LINKS TO EVERY SINGLE IMAGE ARE BROKEN.
I think if there is a beautiful new manual like https://koha-community.org/manual/17.05/html/ it should be the one that Koha links to (instead of the old manuals with the broken image links).
Tell me if I can help correcting this.
Best wishes: Michael
_______________________________________________ Koha mailing list http://koha-community.org Koha@lists.katipo.co.nz https://lists.katipo.co.nz/mailman/listinfo/koha
-- Joy Nelson Director of Migrations ByWater Solutions <http://bywatersolutions.com> Support and Consulting for Open Source Software Office: Fort Worth, TX Phone/Fax (888)900-8944 What is Koha? <http://bywatersolutions.com/what-is-koha/>
There was a bug submitted for this and I submitted a patch >> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817 I'm afraid this will not really solve the problem because as I wrote the Koha help pages are context-sensitive. So your patch will solve the
Hi Joy problem only on the mainpage but not on all the other pages... I have added a comment about this in bug 18817 * https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817 Best wishes: Michael -- Geschäftsführer · Diplombibliothekar BBS, Informatiker eidg. Fachausweis Admin Kuhn GmbH · Pappelstrasse 20 · 4123 Allschwil · Schweiz T 0041 (0)61 261 55 61 · E mik@adminkuhn.ch · W www.adminkuhn.ch
Feel free to submit your own patches for this issues as well! -joy On Mon, Jun 19, 2017 at 11:02 AM, Michael Kuhn <mik@adminkuhn.ch> wrote:
Hi Joy
There was a bug submitted for this and I submitted a patch >>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817
I'm afraid this will not really solve the problem because as I wrote the Koha help pages are context-sensitive. So your patch will solve the problem only on the mainpage but not on all the other pages...
I have added a comment about this in bug 18817 * https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817
Best wishes: Michael -- Geschäftsführer · Diplombibliothekar BBS, Informatiker eidg. Fachausweis Admin Kuhn GmbH · Pappelstrasse 20 · 4123 Allschwil · Schweiz T 0041 (0)61 261 55 61 · E mik@adminkuhn.ch · W www.adminkuhn.ch
-- Joy Nelson Director of Migrations ByWater Solutions <http://bywatersolutions.com> Support and Consulting for Open Source Software Office: Fort Worth, TX Phone/Fax (888)900-8944 What is Koha? <http://bywatersolutions.com/what-is-koha/>
Hi Joy Actually I don't know how "to submit patches". I'm not a developer so I do know how to change files in the file system but I don't know what exactly to do to "write a patch" so it will be accepted by the Koha developers. Maybe you can help me out? Also I saw in your you wrote in your most recent comment to bug 18817 that the link was found 212 times in the system. If I'm right this means the link has to be corrected 212 times for every language. I'm willing to help but for now I'd restrict myself to correct the links in the German interface only. Also I'd be interested what is the most efficient way how to do this because this will take quite some time for everyone involved. Best wishes: Michael Am 19.06.2017 um 20:28 schrieb Joy Nelson:
Feel free to submit your own patches for this issues as well!
-joy
On Mon, Jun 19, 2017 at 11:02 AM, Michael Kuhn <mik@adminkuhn.ch <mailto:mik@adminkuhn.ch>> wrote:
Hi Joy
There was a bug submitted for this and I submitted a patch >> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817>
I'm afraid this will not really solve the problem because as I wrote the Koha help pages are context-sensitive. So your patch will solve the problem only on the mainpage but not on all the other pages...
I have added a comment about this in bug 18817 * https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817>
Best wishes: Michael -- Geschäftsführer · Diplombibliothekar BBS, Informatiker eidg. Fachausweis Admin Kuhn GmbH · Pappelstrasse 20 · 4123 Allschwil · Schweiz T 0041 (0)61 261 55 61 · E mik@adminkuhn.ch <mailto:mik@adminkuhn.ch> · W www.adminkuhn.ch <http://www.adminkuhn.ch>
-- Joy Nelson Director of Migrations
ByWater Solutions <http://bywatersolutions.com> Support and Consulting for Open Source Software **Office: Fort Worth, TX Phone/Fax (888)900-8944 What is Koha? <http://bywatersolutions.com/what-is-koha/>
-- Geschäftsführer · Diplombibliothekar BBS, Informatiker eidg. Fachausweis Admin Kuhn GmbH · Pappelstrasse 20 · 4123 Allschwil · Schweiz T 0041 (0)61 261 55 61 · E mik@adminkuhn.ch · W www.adminkuhn.ch
From there, I set up a server with git to start submitting small 'string'
HI Michael, I'm a librarian myself, not a developer either. A good starting point for learning to submit patches is here: https://koha-community.org/get-involved/for-developers/ For me, I started reading the code and trying to understand what it does. patches. (fixing typos, etc). This URL fix seemed like a nice easy fix until it turned into a bigger issues (212 pages - and where are the translation urls!!) I look forward to seeing you in IRC channel and bugzilla. Maybe once a way forward is found on this issue and the bug is patched you can sign off on it. Thanks joy On Mon, Jun 19, 2017 at 12:46 PM, Michael Kuhn <mik@adminkuhn.ch> wrote:
Hi Joy
Actually I don't know how "to submit patches". I'm not a developer so I do know how to change files in the file system but I don't know what exactly to do to "write a patch" so it will be accepted by the Koha developers. Maybe you can help me out?
Also I saw in your you wrote in your most recent comment to bug 18817 that the link was found 212 times in the system. If I'm right this means the link has to be corrected 212 times for every language. I'm willing to help but for now I'd restrict myself to correct the links in the German interface only. Also I'd be interested what is the most efficient way how to do this because this will take quite some time for everyone involved.
Best wishes: Michael
Am 19.06.2017 um 20:28 schrieb Joy Nelson:
Feel free to submit your own patches for this issues as well!
-joy
On Mon, Jun 19, 2017 at 11:02 AM, Michael Kuhn <mik@adminkuhn.ch <mailto: mik@adminkuhn.ch>> wrote:
Hi Joy
There was a bug submitted for this and I submitted a patch >> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817>
I'm afraid this will not really solve the problem because as I wrote the Koha help pages are context-sensitive. So your patch will solve the problem only on the mainpage but not on all the other pages...
I have added a comment about this in bug 18817 * https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817>
Best wishes: Michael -- Geschäftsführer · Diplombibliothekar BBS, Informatiker eidg. Fachausweis Admin Kuhn GmbH · Pappelstrasse 20 · 4123 Allschwil · Schweiz T 0041 (0)61 261 55 61 · E mik@adminkuhn.ch <mailto:mik@adminkuhn.ch> · W www.adminkuhn.ch < http://www.adminkuhn.ch>
-- Joy Nelson Director of Migrations
ByWater Solutions <http://bywatersolutions.com> Support and Consulting for Open Source Software **Office: Fort Worth, TX Phone/Fax (888)900-8944 What is Koha? <http://bywatersolutions.com/what-is-koha/>
-- Geschäftsführer · Diplombibliothekar BBS, Informatiker eidg. Fachausweis Admin Kuhn GmbH · Pappelstrasse 20 · 4123 Allschwil · Schweiz T 0041 (0)61 261 55 61 · E mik@adminkuhn.ch · W www.adminkuhn.ch
-- Joy Nelson Director of Migrations ByWater Solutions <http://bywatersolutions.com> Support and Consulting for Open Source Software Office: Fort Worth, TX Phone/Fax (888)900-8944 What is Koha? <http://bywatersolutions.com/what-is-koha/>
Hi Joy
I'm a librarian myself, not a developer either. A good starting point for learning to submit patches is here: https://koha-community.org/get-involved/for-developers/
This looks like many hours to spend learning before doing anything productive here...
For me, I started reading the code and trying to understand what it does. From there, I set up a server with git to start submitting small 'string' patches. (fixing typos, etc). This URL fix seemed like a nice easy fix until it turned into a bigger issues (212 pages - and where are the translation urls!!)
I look forward to seeing you in IRC channel and bugzilla. Maybe once a way forward is found on this issue and the bug is patched you can sign off on it.
However it seems like Larry Baerveldt has just resolved the problem by changing directory "en/images" to "en/source/images". That's efficiency the way I like it :-) Best wishes: Michael -- Geschäftsführer · Diplombibliothekar BBS, Informatiker eidg. Fachausweis Admin Kuhn GmbH · Pappelstrasse 20 · 4123 Allschwil · Schweiz T 0041 (0)61 261 55 61 · E mik@adminkuhn.ch · W www.adminkuhn.ch
Hi Michael,
However it seems like Larry Baerveldt has just resolved the problem by changing directory "en/images" to "en/source/images". That's efficiency the way I like it :-) It's a workaround - it now links to the old XML based manual and not the new Sphinx based one. We still need to fix that.
Katrin
Hi Joy
I'm a librarian myself, not a developer either. A good starting point for learning to submit patches is here: https://koha-community.org/get-involved/for-developers/
This looks like many hours to spend learning before doing anything productive here...
I'm new to git (I tried to get into it in the past but I got frustrated at some point because there were so many things that didn't work as expected, and of course like everybody else's my time is limited). I found the following links that describe the installation of Koha with git: * https://wiki.koha-community.org/wiki/Install_and_Setup_Koha_to_use_Git_on_a_... * https://wiki.koha-community.org/wiki/Debian_Jessie_development_setup * https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_git * https://wiki.koha-community.org/wiki/Version_Control_Using_Git Which of these do you think is appropriate? Or should I use the kohadevbox? * https://github.com/digibib/kohadevbox Please advise me where to start. Best wishes: Michael -- Geschäftsführer · Diplombibliothekar BBS, Informatiker eidg. Fachausweis Admin Kuhn GmbH · Pappelstrasse 20 · 4123 Allschwil · Schweiz T 0041 (0)61 261 55 61 · E mik@adminkuhn.ch · W www.adminkuhn.ch
Hi Michael, there is nothing to fix for the German interface - the po file for the help only contains the strings, not the links. We just need to fix the links once in the English templates. You are right in that the links need to be fixed on all the help pages, maybe a good opportunity to read through the help itself at the same time and fix the information there? Writing string change patches like that is usually a good starting point for beginners and documented on the wiki. I also plan to have some instructions on how to update the manual up on the wiki soon. Hope this helps, Katrin On 19.06.2017 20:46, Michael Kuhn wrote:
Hi Joy
Actually I don't know how "to submit patches". I'm not a developer so I do know how to change files in the file system but I don't know what exactly to do to "write a patch" so it will be accepted by the Koha developers. Maybe you can help me out?
Also I saw in your you wrote in your most recent comment to bug 18817 that the link was found 212 times in the system. If I'm right this means the link has to be corrected 212 times for every language. I'm willing to help but for now I'd restrict myself to correct the links in the German interface only. Also I'd be interested what is the most efficient way how to do this because this will take quite some time for everyone involved.
Best wishes: Michael
Am 19.06.2017 um 20:28 schrieb Joy Nelson:
Feel free to submit your own patches for this issues as well!
-joy
On Mon, Jun 19, 2017 at 11:02 AM, Michael Kuhn <mik@adminkuhn.ch <mailto:mik@adminkuhn.ch>> wrote:
Hi Joy
There was a bug submitted for this and I submitted a patch >> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817>
I'm afraid this will not really solve the problem because as I wrote the Koha help pages are context-sensitive. So your patch will solve the problem only on the mainpage but not on all the other pages...
I have added a comment about this in bug 18817 * https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817 <https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18817>
Best wishes: Michael -- Geschäftsführer · Diplombibliothekar BBS, Informatiker eidg. Fachausweis Admin Kuhn GmbH · Pappelstrasse 20 · 4123 Allschwil · Schweiz T 0041 (0)61 261 55 61 · E mik@adminkuhn.ch <mailto:mik@adminkuhn.ch> · W www.adminkuhn.ch <http://www.adminkuhn.ch>
-- Joy Nelson Director of Migrations
ByWater Solutions <http://bywatersolutions.com> Support and Consulting for Open Source Software **Office: Fort Worth, TX Phone/Fax (888)900-8944 What is Koha? <http://bywatersolutions.com/what-is-koha/>
participants (4)
-
Chris Cormack -
Joy Nelson -
Katrin -
Michael Kuhn