[Koha] DB errors during upgrade from 3.18.09 to 3.20.04

[Doug Kingston]

Here's the full text from the update.  Note the two "DEV" entries at the
bottom that appear to be related to these two errors.

Updating database structure

Update report :

   - Upgrade to 3.19.00.000 done (there's life after 3.18)
   - Upgrade to 3.19.00.001 done (Bug 13436: Add more options to
   UsageStatsLibraryType)
   - upgrade to 3.19.00.002 done (Bug 10753: replace __ANY__ with empty
   string in suggestions.branchcode)
   - Upgrade to 3.19.00.003 done (Bug 1861: Unique patrons logins not
   (totally) enforced)
   - Upgrade to 3.19.00.004 done (Bug 13346: OpacExportOptions is now
   multiple)
   - Upgrade to 3.19.00.005 done (Bug 13379: Modify
   authorised_values.category to varchar(32))
   - Upgrade to 3.19.00.006 done (Bug 11944: Convert DB tables to
   utf8_unicode_ci)
   - Upgrade to 3.19.00.007 done (Bug 12905: Check budget integrity: OK)
   - Upgrade to 3.19.00.008 done (Bug 12601: Add new foreign key
   aqorders.budget_id)
   - Upgrade to 3.19.00.009 done (Bug 13007: Add new foreign key
   suggestions.budgetid)
   - Upgrade to 3.19.00.010 done (Bug 5511: SessionRestrictionByIP)
   - Upgrade to 3.19.00.011 done (Bug 13417: Add permission to delete
   public lists)
   - Upgrade to 3.19.00.012 done (Bug 13523 Remove NOT NULL restriction on
   field marcxml due to mysql STRICT_TRANS_TABLES)
   - Upgrade to 3.19.00.013 done (Bug 11395: Add permission
   tools_records_batchmod)
   - Upgrade to 3.19.00.014 done (Bug 12648: Add letter ACQ_NOTIF_ON_RECEIV
   )
   - Upgrade to 3.19.00.015 done (Bug 11430: Add primary key for
   search_history)
   - Upgrade to 3.19.00.016 done (Bug 13380: ORDER_CANCELLATION_REASON
   authorised value already existed from earlier update!)
   - Upgrade to 3.19.00.017 done (Bug 5786: Move AllowOnShelfHolds to
   circulation matrix; Move OPACItemHolds system preference to circulation
   matrix)
   - Upgrade to 3.19.00.018 done (Bug 10328: Rename opaccolorstylesheet to
   OpacAdditionalStylesheet
   - Upgrade to 3.19.00.019 done (Bug 9580: Cover image from Coce, a remote
   image URL cache)
   - Upgrade to 3.19.00.020 done (Bug 11008: DROP column
   aqorders.supplierreference)
   - Upgrade to 3.19.00.021 done (Bug 2806: Remove issuingbranch columns)
   - Upgrade to 3.19.00.022 done (Bug 13006: Drop column
   suggestion.mailoverseeing)
   - Upgrade to 3.19.00.023 done (Bug 13497: Remove the AddPatronLists
   system preferences)
   - Upgrade to 3.19.00.024 done (Bug 13539: Remove table patroncards from
   database as it's no longer in use)
   - Upgrade to 3.19.00.025 done (Bug 13528: Add the
   SearchWithISBNVariations syspref)
   - Upgrade to 3.19.00.026 done (Bug 13322: Update MARC21 frameworks to
   Update No. 19 - October 2014)
   - Upgrade to 3.19.00.027 done (Bug 4222: Nonpublic note not appearing in
   the staff client) <b>Please check each of your frameworks to ensure your
   non-public item notes are mapped to items.itemnotes_nonpublic. After doing
   so please have your administrator run misc/batchRebuildItemsTables.pl </b>)
   - Upgrade to 3.19.00.028 done (Bug 13790: Add unique id issue_id to
   issues and oldissues tables)
   - Upgrade to 3.19.00.029 done (Bug 13606: Upgrade sessions.a_session to
   MEDIUMTEXT)
   - Upgrade to 3.19.00.030 done (Bug 14030: Add Georgian language and fix
   Kannada language code)
   - Upgrade to 3.19.00.031 done (Bug 8992: Add system preference IdRef))
   - Upgrade to 3.19.00.032 done (Bug 4041: Address Format as a I18N/L10N
   system preference
   - Upgrade to 3.19.00.033 done (Bug 11165: Update
   auth_header.datemodified when updated)
   - Upgrade to 3.19.00.034 done (Bug 13984: CardnumberLength syspref
   missing on some setups
   - Upgrade to 3.19.00.035 done (Bug 8007: Add System Preferences
   useDischarge, the discharge notice and the new table discharges)
   - Upgrade to 3.19.00.036 done (Bug 13889: Add cron jobs information to
   system log)
   - Upgrade to 3.19.00.037 done (Bug 13810: Change collate for tagsubfield
   (utf8_bin))
   - Upgrade to 3.19.00.038 done (Bug 13421: Add DB field
   virtualshelves.created_on)
   - Upgrade to 3.19.00.039 done (Koha 3.20 beta)
   - Upgrade to 3.19.00.040 done (Bug 11006: Drop column
   aqorders.totalamount)
   - Upgrade to 3.19.00.041 done (Bug 14132: suggestions table is missing
   indexes)
   - Upgrade to 3.19.00.042 done (Bug 8480: Add foreign key on
   auth_subfield_structure.authtypecode)
   - Upgrade to 3.19.00.043 done (Bug 5338: Add Serial to the report groups
   if does not exist)
   - Upgrade to 3.20.00.000 done (Koha 3.20)
   - Upgrade to 3.20.00.001 done (Bug 14285: Add new region India)
   - Upgrade to 3.20.00.002 done (Bug 5010: Fix OPACBaseURL to include
   protocol)
   - Upgrade to 3.20.01.000 done (Koha 3.20.1)
   - Upgrade to 3.20.01.001 done (Bug 9942: Privacy is correctly set)
   - Upgrade to 3.20.01.002 done (Bug 13993: Correct orderstatus for
   transferred orders)
   - Upgrade to 3.20.02.000 done (Koha 3.20.2)
   - Upgrade to 3.20.03.000 done (Koha 3.20.3)
   - Upgrade to 3.20.03.001 done (Bug 14205: Deleting an Item/Record does
   not remove link to course reserve)
   - Upgrade to 3.20.03.002 done (Bug 14717: Prevent 0000-00-00 dates in
   patron data)
   - Upgrade to 3.20.03.003 done (Bug 14298: AutoSelfCheckID user should
   only be able to access SCO )
   - Upgrade to 3.20.04.000 done (Koha 3.20.4)
   - DEV atomic update: hourlyloans.sql
   - DEV atomic update: oai_sets.sql

Update errors :

   - [Sat Oct 24 23:52:23 2015] updatedatabase.pl: C4::Installer::load_sql
   returned the following errors while attempting to load
   /home/koha/koha-test/intranet/cgi-bin/installer/data/mysql/atomicupdate/hourlyloans.sql:
   - [Sat Oct 24 23:52:23 2015] updatedatabase.pl: ERROR 1060 (42S21) at
   line 1: Duplicate column name 'lengthunit'
   - [Sat Oct 24 23:52:23 2015] updatedatabase.pl: C4::Installer::load_sql
   returned the following errors while attempting to load
   /home/koha/koha-test/intranet/cgi-bin/installer/data/mysql/atomicupdate/oai_sets.sql:
   - [Sat Oct 24 23:52:23 2015] updatedatabase.pl: ERROR 1062 (23000) at
   line 35: Duplicate entry 'OAI-PMH:AutoUpdateSets' for key 'PRIMARY'


On Sun, Oct 25, 2015 at 11:05 AM, Doug Kingston <dpk at randomnotes.org> wrote:

> While doing a upgrade on our test koha instance (based on a copy of
> production), I received the following errors.:
>
>    - [Sat Oct 24 23:52:23 2015] updatedatabase.pl:
>    C4::Installer::load_sql returned the following errors while attempting to
>    load
>    /home/koha/koha-test/intranet/cgi-bin/installer/data/mysql/atomicupdate/hourlyloans.sql:
>    - [Sat Oct 24 23:52:23 2015] updatedatabase.pl: ERROR 1060 (42S21) at
>    line 1: Duplicate column name 'lengthunit'
>    - [Sat Oct 24 23:52:23 2015] updatedatabase.pl:
>    C4::Installer::load_sql returned the following errors while attempting to
>    load
>    /home/koha/koha-test/intranet/cgi-bin/installer/data/mysql/atomicupdate/oai_sets.sql:
>    - [Sat Oct 24 23:52:23 2015] updatedatabase.pl: ERROR 1062 (23000) at
>    line 35: Duplicate entry 'OAI-PMH:AutoUpdateSets' for key 'PRIMARY'
>
> I know from previous experience that these kinds of error are sometimes
> benign, but I would like some feedback on whether I need to take any kind
> of action in this particular case.
>
> Thanks,
>   -Doug-
>
>