[Koha] Bug in mainpage.pl?

[Bob Ewart]

The latest version of CGI puts out that warning every time a statement 
of the form "$xxx = $cgi->param('yyy);" is executed.
It should be changed to "$xxx = scalar $cgi->param('yyy');" and exists 
throughout Koha.

My koha-opac-error_log currently contains about 1M of the warnings.  It 
doesn't hurt anything, but is a pain when trying to debug code.


On 07/21/2015 10:04 AM, Angel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA256
>
> Hello all.
>
> I've just installed kohan on Debian Jessie, I'm testing and
> configuring, sometimes I get screen warning to not connect to server.
> In intranet-error.log I can see errors in cgi:
>
> "search.pl: CGI::param called in list context from package main line
> 169, this can lead to vulnerabilities. See the warning in "Fetching
> the value or values of a single named parameter" at
> /usr/share/perl5/CGI.pm line 436."
>
> I was searchig for the warning, and it seems that mainpage.pl in
> koha-common needs to be fixed, but I don't know how. Or perhaps there
> is other way avoid the error.
>
> REgards and thanks in advanced
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQIcBAEBCAAGBQJVrlFyAAoJEPploz+wCpxHPN0P/i2j4kMbdDriaaak3mhakKKM
> pKSvTEP1o7oundpI33JYuWFse6c+UGc5m2RfQwtaVWQVNB1zIz4MIS4JPnuS5xOK
> CHU/ZE+CJ0mMpDdqbHTcXUFGyU8oECmU/N3I2FmOCSnG8ZSIIGf8SDRPMZ+zS2of
> 9MJp84DnGT8grblS0HqreyhuCrD0iuRF1U/p6ed39hBm+b2IGqVHvus3ptM67346
> Lih5pdKrJ+mXwUVpL5NCFD7fCOAlU102JUPJBUkqWXCIWz03uWhDFt3GmT2ShOLR
> gncWk1x+kWtwhSvcsXP4ffpcVuzq84C7zSKcLMHzVQqqxScLs3ZRZVOQAp3jo8lf
> S/rBOPJPtUbvW5okywfusGx+XKftfiugboU5ueAL8hdS8JQ/uM/BYqfop21qY+el
> XKWhy5LQ0vA6liWFdCPZZkustjTxXHp1jpLNwNcOfE+lpdCKaThjA0zlxOstkOLw
> lfaVb8h1Ayi1l7a3luFhDVp9E8Gj08vcs9CivCYVAjNh+KqHhHuYx5Jl0eF3demo
> yUiecWuLiVDtQYjOe8j45jQ0F/zuN4uzL6dGIvQ5etIEPVucSasUxGU+QJwVVGNk
> 2BTfNorN/JNwZkDfmQy75gMwCSSCAqsv2rCKaNLGYhOSXl4TtVo94xPqaUZJa1JS
> iH42vkC9D46wgOIFcj6v
> =Wghn
> -----END PGP SIGNATURE-----
> _______________________________________________
> Koha mailing list  http://koha-community.org
> Koha at lists.katipo.co.nz
> https://lists.katipo.co.nz/mailman/listinfo/koha