Reserves problem
hi all, I have a problem with a Koha 2.2.8 - when I log into the opac-user.pl page, I get an internal server error. When I looked into the error log, I found the following: HTML::Template->output() : fatal error in loop output : HTML::Template::param() : attempt to set parameter 'reserves' with an array ref - parameter is not a TMPL_LOOP! at /usr/lib/perl5/site_perl/ 5.8.8/HTML/Template.pm line 3069, referer: http://xxxxx:8000/cgi-bin/ koha/opac-user.pl [Wed May 30 22:35:44 2007] [error] [client XXX.XXX.XXX.XXX] at /usr/ local/koha/opac/cgi-bin/opac-user.pl line 160, referer: http://xxxxx: 8000/cgi-bin/koha/opac-user.pl [Wed May 30 22:35:44 2007] [error] [client XXX.XXX.XXX.XXX] Premature end of script headers: opac-user.pl, referer: http://xxxxx:8000/cgi- bin/koha/opac-user.pl When I looked into the /usr/local/koha/opac/opac-user.pl file, I found I can prevent the errors if I comment out line 123. This then allows me to logon, but not view any reserves for the user. 123 #$template->param(RESERVES => $reserves); Anyone come across this problem, or have any suggestions for me? It appears to be a software bug in Koha, but if that was the case, I would have expected other people to have found it as well.... Koha is installed on a CentOS/RHEL 5 server. thanks, -- Jethro Carr
On 7/06/2007, at 11:43 AM, Jethro Carr wrote:
hi all,
I have a problem with a Koha 2.2.8 - when I log into the opac- user.pl page, I get an internal server error.
When I looked into the error log, I found the following:
HTML::Template->output() : fatal error in loop output : HTML::Template::param() : attempt to set parameter 'reserves' with an array ref - parameter is not a TMPL_LOOP! at /usr/lib/perl5/ site_perl/5.8.8/HTML/Template.pm line 3069, referer: http://xxxxx: 8000/cgi-bin/koha/opac-user.pl [Wed May 30 22:35:44 2007] [error] [client XXX.XXX.XXX.XXX] at /usr/ local/koha/opac/cgi-bin/opac-user.pl line 160, referer: http:// xxxxx:8000/cgi-bin/koha/opac-user.pl [Wed May 30 22:35:44 2007] [error] [client XXX.XXX.XXX.XXX] Premature end of script headers: opac-user.pl, referer: http:// xxxxx:8000/cgi-bin/koha/opac-user.pl
Hi Jethro This sounds like a bug in the template file, do you recall what version of the templates they are running for the opac? You can find out in the system preferences in the librarian interface Chris -- Chris Cormack chris.cormack@liblime.com VP Research and Development www.liblime.com LibLime +64 21 542 131
On 7/06/2007, at 12:04 PM, Chris Cormack wrote:
On 7/06/2007, at 11:43 AM, Jethro Carr wrote:
hi all,
I have a problem with a Koha 2.2.8 - when I log into the opac- user.pl page, I get an internal server error.
When I looked into the error log, I found the following:
HTML::Template->output() : fatal error in loop output : HTML::Template::param() : attempt to set parameter 'reserves' with an array ref - parameter is not a TMPL_LOOP! at /usr/lib/perl5/ site_perl/5.8.8/HTML/Template.pm line 3069, referer: http://xxxxx: 8000/cgi-bin/koha/opac-user.pl [Wed May 30 22:35:44 2007] [error] [client XXX.XXX.XXX.XXX] at / usr/local/koha/opac/cgi-bin/opac-user.pl line 160, referer: http:// xxxxx:8000/cgi-bin/koha/opac-user.pl [Wed May 30 22:35:44 2007] [error] [client XXX.XXX.XXX.XXX] Premature end of script headers: opac-user.pl, referer: http:// xxxxx:8000/cgi-bin/koha/opac-user.pl
Hi Jethro
This sounds like a bug in the template file, do you recall what version of the templates they are running for the opac? You can find out in the system preferences in the librarian interface
thanks Chris, Unfortunately there doesn't seem to be any entries in the system preferences for what version of the templates they are running. However, the templates used are the ones packaged with Koha 2.2.8. cheers, -- Jethro Carr Prophecy Networks Ltd Level 5, Hallenstein House 276-278 Lambton Quay Wellington PO Box: 25-200 Mobile: +64 21-977-207 Land: +64 4-910-3000
thanks Chris,
Unfortunately there doesn't seem to be any entries in the system preferences for what version of the templates they are running. However, the templates used are the ones packaged with Koha 2.2.8.
Hmm there should be, under the opac tab, in system preferences, http://koha.liblime.com/cgi-bin/koha/admin/systempreferences.pl?tab=OPAC It will be called opacthemes. 2 sets of templates come standard with 2.2.8, npl and css, so we want to find out which one of those its using so we can check the appropriate .tmpl file Chris -- Chris Cormack chris.cormack@liblime.com VP Research and Development www.liblime.com LibLime +64 21 542 131
On 7/06/2007, at 1:20 PM, Chris Cormack wrote:
thanks Chris,
Unfortunately there doesn't seem to be any entries in the system preferences for what version of the templates they are running. However, the templates used are the ones packaged with Koha 2.2.8.
Hmm there should be, under the opac tab, in system preferences, http://koha.liblime.com/cgi-bin/koha/admin/systempreferences.pl? tab=OPAC
It will be called opacthemes.
2 sets of templates come standard with 2.2.8, npl and css, so we want to find out which one of those its using so we can check the appropriate .tmpl file
hi Chris, Interesting - when I access the systempreferences.pl page, I get a different set of parameters to what I get when I access systempreferences.pl?tab=OPAC. :-/ opacthemes is set to default. cheers, -- Jethro Carr Prophecy Networks Ltd Level 5, Hallenstein House 276-278 Lambton Quay Wellington PO Box: 25-200 Mobile: +64 21-977-207 Land: +64 4-910-3000
Hi Jethro
hi Chris,
Interesting - when I access the systempreferences.pl page, I get a different set of parameters to what I get when I access systempreferences.pl?tab=OPAC. :-/
Ah yes you should, there should be a bunch of different tabs you can click on, opac, admin, intranet etc.
opacthemes is set to default.
Right, you could try changing that to npl, and see if it now works Chris -- Chris Cormack chris.cormack@liblime.com VP Research and Development www.liblime.com LibLime +64 21 542 131
On Thu, June 7, 2007 08:04, Chris Cormack wrote:
This sounds like a bug in the template file, do you recall what version of the templates they are running for the opac? You can find out in the system preferences in the librarian interface
Hi Guys, I believe these previous posts are definitely related to this one: http://article.gmane.org/gmane.comp.misc.koha/7751 http://article.gmane.org/gmane.comp.misc.koha/7665 I'm using the standard npl templates released with 2.9.9 PLEASE developers if any you read this, help up sort this out. Merci beaucoup!! It is surely just a tiny mistake in the code somewhere... Bo
On 7/06/2007, at 3:40 PM, Bo Schafers wrote:
Hi Guys,
I believe these previous posts are definitely related to this one:
http://article.gmane.org/gmane.comp.misc.koha/7751 http://article.gmane.org/gmane.comp.misc.koha/7665
I'm using the standard npl templates released with 2.9.9
PLEASE developers if any you read this, help up sort this out. Merci beaucoup!! It is surely just a tiny mistake in the code somewhere...
Im one of the developers, and i am trying to help people sort it out :) Right well looking at the npl template for 2.2.9 for opac- user.tmpl .... I cant see where this is coming from. The only RESERVES I can see in the template is <!-- TMPL_LOOP NAME="RESERVES" --> Which most certainly is a TMPL_LOOP ... I wonder Bo, can you mail me off list a copy of the opac-user.tmpl and opac-user.pl files ... there must be something different that I cant spot Chris -- Chris Cormack chris.cormack@liblime.com VP Research and Development www.liblime.com LibLime +64 21 542 131
On 7/06/2007, at 3:07 PM, Chris Cormack wrote:
Right well looking at the npl template for 2.2.9 for opac- user.tmpl .... I cant see where this is coming from.
The only RESERVES I can see in the template is <!-- TMPL_LOOP NAME="RESERVES" -->
Which most certainly is a TMPL_LOOP ... I wonder Bo, can you mail me off list a copy of the opac-user.tmpl and opac-user.pl files ... there must be something different that I cant spot
FYI: I've emailed Chris a copy of opac-user.pl, and opac-user.tmpl. I took a look into the template file, but like Chris, I found that it is certainly a TMPL_LOOP. :-/ Chris: Perhaps take a look at the code relating to the issue list above? That does a similar function and works fine. I tried working out what the difference is, but is a bit hard for me to understand what is happening, due to my unfamiliarity with the Koha codebase. :-) -- Jethro Carr Prophecy Networks Ltd Level 5, Hallenstein House 276-278 Lambton Quay Wellington PO Box: 25-200 Mobile: +64 21-977-207 Land: +64 4-910-3000
On 7/06/2007, at 3:43 PM, Jethro Carr wrote:
t
FYI: I've emailed Chris a copy of opac-user.pl, and opac-user.tmpl.
I took a look into the template file, but like Chris, I found that it is certainly a TMPL_LOOP. :-/
Just an update for those following this problem. It appears this problem only occurs with HTML::Template version 2.9, I was running 2.8 and things were working fine. Both Jethro and Bo are running 2.9. I upgraded to version 2.9 and bang internal server error. So something has changed in HTML::Template between 2.8 and 2.9 that has meant it no longer works. Other TMPL_LOOP's seem to be working okay, so there must be something special about this one that is causing it to break. Chris -- Chris Cormack chris.cormack@liblime.com VP Research and Development www.liblime.com LibLime +64 21 542 131
On 7/06/2007, at 9:27 PM, Chris Cormack wrote:
On 7/06/2007, at 3:43 PM, Jethro Carr wrote:
t
FYI: I've emailed Chris a copy of opac-user.pl, and opac-user.tmpl.
I took a look into the template file, but like Chris, I found that it is certainly a TMPL_LOOP. :-/
Just an update for those following this problem. It appears this problem only occurs with HTML::Template version 2.9, I was running 2.8 and things were working fine. Both Jethro and Bo are running 2.9. I upgraded to version 2.9 and bang internal server error. So something has changed in HTML::Template between 2.8 and 2.9 that has meant it no longer works.
Other TMPL_LOOP's seem to be working okay, so there must be something special about this one that is causing it to break.
Ok, So this is bizarre, If I change $template->param(RESERVES => $reserves); to $template->param(RESERVE => $reserves); In opac-user.pl And then change <!-- TMPL_LOOP NAME="RESERVES" --> to <!-- TMPL_LOOP NAME="RESERVE" --> in opac-user.tmpl Suddenly the error goes away. If either of you could confirm this works for you, that would be great, and ill commit it to cvs, so that it comes out in the next version ... weird Chris -- Chris Cormack chris.cormack@liblime.com VP Research and Development www.liblime.com LibLime +64 21 542 131
I can confirm that my problem has gone away :-) :-) :-) :-) Well done and THANK YOU - Chris !!!! Best Regards, Bo Chris Cormack wrote:
Suddenly the error goes away. If either of you could confirm this works for you, that would be great, and ill commit it to cvs, so that it comes out in the next version ... weird
On 7/06/2007, at 9:45 PM, Chris Cormack wrote:
On 7/06/2007, at 9:27 PM, Chris Cormack wrote:
On 7/06/2007, at 3:43 PM, Jethro Carr wrote:
t
FYI: I've emailed Chris a copy of opac-user.pl, and opac-user.tmpl.
I took a look into the template file, but like Chris, I found that it is certainly a TMPL_LOOP. :-/
Just an update for those following this problem. It appears this problem only occurs with HTML::Template version 2.9, I was running 2.8 and things were working fine. Both Jethro and Bo are running 2.9. I upgraded to version 2.9 and bang internal server error. So something has changed in HTML::Template between 2.8 and 2.9 that has meant it no longer works.
Other TMPL_LOOP's seem to be working okay, so there must be something special about this one that is causing it to break.
Ok,
So this is bizarre, If I change $template->param(RESERVES => $reserves); to $template->param(RESERVE => $reserves);
In opac-user.pl
And then change <!-- TMPL_LOOP NAME="RESERVES" --> to <!-- TMPL_LOOP NAME="RESERVE" -->
in opac-user.tmpl
Suddenly the error goes away. If either of you could confirm this works for you, that would be great, and ill commit it to cvs, so that it comes out in the next version ... weird
awesome, that works for me too. :-) Weird problem - perhaps the RESERVES variable is getting used somewhere else and is clashing with the usage in opac-users? Thanks for the help Chris, it's appreciated. :-) -- Jethro Carr Prophecy Networks Ltd Level 5, Hallenstein House 276-278 Lambton Quay Wellington PO Box: 25-200 Mobile: +64 21-977-207 Land: +64 4-910-3000
On Thu, June 7, 2007 11:07, Chris Cormack wrote:
Im one of the developers, and i am trying to help people sort it out :)
I can only reflect on how fortunate we are to actually have access to you developers. Thank you so much for givig up your time for the rest of us.
.... a copy of the opac-user.tmpl and opac-user.pl files ... there must be something different that I cant spot
I'm at work right now, as soon as I get home tonight I'll send them on. And again, thanks :-D Bo
Bo Schafers wrote:
I can only reflect on how fortunate we are to actually have access to you developers. Thank you so much for givig up your time for the rest of us.
Chris Cormack wrote:
.... a copy of the opac-user.tmpl and opac-user.pl files ... there must be something different that I cant spot
FWIW, I downloaded and examined the two latest versions of HTML::Template. There are quite a few differences between the two. I did a case- insensitive grep for "reserve" through both source sets and found little of interest. Finally I grepped all of Koha/2.2.9 for the same and did not see anything unusual. As a matter of fact, "RESERVES" is used many scripts and templates, not just in the one that is failing. It will be interesting to read what the cause of this particular bug is. It is in the weirdo category fer sure. cheers rickw -- _________________________________ Rick Welykochy || Praxis Services We are ready for any unforeseen event that may or may not occur. -- Al Gore, Vice President
Hi Jethro, Had a similar problem a while back on both npl and default templates (i.e error when trying to login)-- koha 2.2.8 on Centos 4.4, perl 5.8.8 Solved it by downgrading my HTML::Template to a lower version I had (2.7 I think ...) and everything works just fine now On Thu, 2007-06-07 at 11:43 +1200, Jethro Carr wrote:
hi all,
I have a problem with a Koha 2.2.8 - when I log into the opac-user.pl page, I get an internal server error.
When I looked into the error log, I found the following:
HTML::Template->output() : fatal error in loop output : HTML::Template::param() : attempt to set parameter 'reserves' with an array ref - parameter is not a TMPL_LOOP! at /usr/lib/perl5/site_perl/ 5.8.8/HTML/Template.pm line 3069, referer: http://xxxxx:8000/cgi-bin/ koha/opac-user.pl [Wed May 30 22:35:44 2007] [error] [client XXX.XXX.XXX.XXX] at /usr/ local/koha/opac/cgi-bin/opac-user.pl line 160, referer: http://xxxxx: 8000/cgi-bin/koha/opac-user.pl [Wed May 30 22:35:44 2007] [error] [client XXX.XXX.XXX.XXX] Premature end of script headers: opac-user.pl, referer: http://xxxxx:8000/cgi- bin/koha/opac-user.pl
When I looked into the /usr/local/koha/opac/opac-user.pl file, I found I can prevent the errors if I comment out line 123. This then allows me to logon, but not view any reserves for the user. 123 #$template->param(RESERVES => $reserves);
Anyone come across this problem, or have any suggestions for me? It appears to be a software bug in Koha, but if that was the case, I would have expected other people to have found it as well....
Koha is installed on a CentOS/RHEL 5 server.
thanks,
participants (5)
-
Bernard Shiundu -
Bo Schafers -
Chris Cormack -
Jethro Carr -
Rick Welykochy