[Discussion tech] Generalise the use Template Toolkit plugins
I've started another discussion page: http://wiki.koha-community.org/wiki/Generalise_the_use_Template_Toolkit_plug... Chris_c recently has added a plugin to manage the display of dates into Koha (see http://wiki.koha-community.org/wiki/Coding_Guidelines#Displaying_dates), that is very interesting. Do we want to generalise this mechanism ? When do we want to use it ? For example, the patch for bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 could nicely use this mechanism let's start the discussion ! (reading the page and the possible solutions, you'll see I made 2, but am not happy with them. Probably need others ideas...) -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08
I would say here that a general rule is hard to make. Even disapproving a patch only for the reason of not using a plugin is "discussionable". Current Koha does a lot of things in a lot of ways. Standardizing with routines and plugins is a continuous educational project.. ________________________________________ Van: koha-devel-bounces@lists.koha-community.org [koha-devel-bounces@lists.koha-community.org] namens Paul Poulain [paul.poulain@biblibre.com] Verzonden: vrijdag 10 februari 2012 12:24 To: koha-devel@lists.koha-community.org; Koha-Mailinglist Onderwerp: [Koha-devel] [Discussion tech] Generalise the use Template Toolkit plugins I've started another discussion page: http://wiki.koha-community.org/wiki/Generalise_the_use_Template_Toolkit_plug... Chris_c recently has added a plugin to manage the display of dates into Koha (see http://wiki.koha-community.org/wiki/Coding_Guidelines#Displaying_dates), that is very interesting. Do we want to generalise this mechanism ? When do we want to use it ? For example, the patch for bug http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4078 could nicely use this mechanism let's start the discussion ! (reading the page and the possible solutions, you'll see I made 2, but am not happy with them. Probably need others ideas...) -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08 _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
On 13 February 2012 20:11, Marcel de Rooy <M.de.Rooy@rijksmuseum.nl> wrote:
I would say here that a general rule is hard to make. Even disapproving a patch only for the reason of not using a plugin is "discussionable". Current Koha does a lot of things in a lot of ways. Standardizing with routines and plugins is a continuous educational project..
+1 ! I agree completely. Chris
Le 13/02/2012 08:12, Chris Cormack a écrit :
On 13 February 2012 20:11, Marcel de Rooy <M.de.Rooy@rijksmuseum.nl> wrote:
I would say here that a general rule is hard to make. Even disapproving a patch only for the reason of not using a plugin is "discussionable". Current Koha does a lot of things in a lot of ways. Standardizing with routines and plugins is a continuous educational project..
I agree completely. I also agree completely too: Koha does a lot of things in a lot of ways. Maybe we don't conclude the same things: my conclusion is that we must coordinate & organize things as much as possible.
So, my preference would go to: * it's too hard to make a general rule for display plugins. There would be too many possibilities to imagine. * for bug 4078, we should ask for a plugin though: looking at the code, it introduces dozens of: + $something = PlaceCurrencySymbol($something); Those will add complexity to the code, if one day $something must be reused after the PlaceCurrencySymbol has been applied, there will be side effects. There are *bad* things like: + $$item{field} = PlaceCurrencySymbol($$item{field}) if ($$item{field} =~ /^\d+\.\d\d$/); in the patch : they'll display a currency just in case something is numeric with 2 decimals. That can be the case of a dewey code, librarians won't like seeing a $ or € on their dewey ;-) I'll ask for an alternate patch on the bug itself, it's really a nice feature but Aleksa probably missed the T::T plugin (great) feature ! -- Paul POULAIN http://www.biblibre.com Expert en Logiciels Libres pour l'info-doc Tel : (33) 4 91 81 35 08
participants (3)
-
Chris Cormack -
Marcel de Rooy -
Paul Poulain