Circulation bug which affects CART functionality
Hi All - like a lot of libraries we've been testing the Cart functionality to place returned items into quarantine for X hours. We are running 19.11.04. We have the "UpdateItemLocationOnCheckin" syspref set to: _ALL_: CART When we return items they do go into the Cart, but the location isn't stored in the "permanent_location" field. This means that when the item comes out of the Cart, the location field is set to null because the previous location wasn't stored. I know the Uni of Arts London (18.11) are experiencing this issue. Are others? Looking at the code that deals with this in the Circulation.pm module I cannot see the permanent_location being set, but it's the first time I have looked at this so I may be overlooking something. I have done some quick testing and if I changed this: if ( $item->location ne $update_loc_rules->{_ALL_}) { $messages->{'ItemLocationUpdated'} = { from => $item->location, to => $update_loc_rules->{_ALL_} }; ModItem( { location => $update_loc_rules->{_ALL_}}, undef, $itemnumber ); } To: if ( $item->location ne $update_loc_rules->{_ALL_}) { $messages->{'ItemLocationUpdated'} = { from => $item->location, to => $update_loc_rules->{_ALL_} }; ModItem( { location => $update_loc_rules->{_ALL_}, permanent_location => $item->location }, undef, $itemnumber ); } , then it appears to solve it, but would need proper testing!!! Cheers, Stephen -------------------------------------- Stephen Graham Library Technology Consultant Content and Collections Team Library and Computing Services University of Hertfordshire Tel: 01707 286111 Ext: 77751 Email: s.graham4@herts.ac.uk<mailto:s.graham4@herts.ac.uk>
It seems that we assume permanent_location must be set. I would recommend updating your data and set the items.permenant_location=items.location when it's not defined. Le mar. 11 août 2020 à 17:47, Stephen Graham <s.graham4@herts.ac.uk> a écrit :
Hi All - like a lot of libraries we've been testing the Cart functionality to place returned items into quarantine for X hours. We are running 19.11.04.
We have the "UpdateItemLocationOnCheckin" syspref set to:
_ALL_: CART
When we return items they do go into the Cart, but the location isn't stored in the "permanent_location" field. This means that when the item comes out of the Cart, the location field is set to null because the previous location wasn't stored.
I know the Uni of Arts London (18.11) are experiencing this issue. Are others?
Looking at the code that deals with this in the Circulation.pm module I cannot see the permanent_location being set, but it's the first time I have looked at this so I may be overlooking something.
I have done some quick testing and if I changed this:
if ( $item->location ne $update_loc_rules->{_ALL_}) { $messages->{'ItemLocationUpdated'} = { from => $item->location, to => $update_loc_rules->{_ALL_} }; ModItem( { location => $update_loc_rules->{_ALL_}}, undef, $itemnumber ); }
To:
if ( $item->location ne $update_loc_rules->{_ALL_}) { $messages->{'ItemLocationUpdated'} = { from => $item->location, to => $update_loc_rules->{_ALL_} }; ModItem( { location => $update_loc_rules->{_ALL_}, permanent_location => $item->location }, undef, $itemnumber ); }
, then it appears to solve it, but would need proper testing!!!
Cheers, Stephen
-------------------------------------- Stephen Graham Library Technology Consultant Content and Collections Team Library and Computing Services University of Hertfordshire Tel: 01707 286111 Ext: 77751 Email: s.graham4@herts.ac.uk<mailto:s.graham4@herts.ac.uk>
_______________________________________________
Koha mailing list http://koha-community.org Koha@lists.katipo.co.nz Unsubscribe: https://lists.katipo.co.nz/mailman/listinfo/koha
participants (2)
-
Jonathan Druart -
Stephen Graham