RE: [Koha] z3950 problem found to be bug #511
Paul, I installed the new addbiblio.tmpl and still had the problem. I did some working on the PopZ3950 function and found the real problem to be a space in the title parameter for the window.open function. Previously: newin=window.open('...', 'Z3950 Search', '....'); Now: reviously: newin=window.open('...', 'Z3950Search', '....'); And the search window pops up as it should. I don't know if this is a bug in addbiblio.tmpl or Internet Explorer, but either way the above change corrects the problem. I haven't replied yet because my search does not find anything when looking for an ISBN from the Library of Congress. I do a search from the LOC website directly and find it. So I have another issue I'm working on. Tim -----Original Message----- From: paul POULAIN [mailto:paul.poulain@free.fr] Sent: Friday, September 12, 2003 7:13 AM To: Tim Stevens Subject: Re: [Koha] z3950 problem found to be bug #511 Tim Stevens wrote:
Paul, I just checked the cvs on sourceforge, and only saw the files I downloaded yesterday in cvs: addbiblio.pl and addbiblio.tmpl. Am I looking in the wrong place?
if you look through cvsweb, yes, it's a wrong place. SF has perf problems with cvsweb and show backup, not real cvs since july. cvsweb maybe 1-2 days different from "true cvs". I can see koha-tmpl/intranet-tmpl/default/en/acqui.simple/addbiblio.tmpl is in v1.22 The only difference is in the PopupZ3950() sub (end of template), that has NO MORE parameters. -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
Tim Stevens wrote:
Paul,
I installed the new addbiblio.tmpl and still had the problem. I did some working on the PopZ3950 function and found the real problem to be a space in the title parameter for the window.open function.
Previously: newin=window.open('...', 'Z3950 Search', '....');
Now: reviously: newin=window.open('...', 'Z3950Search', '....');
And the search window pops up as it should. I don't know if this is a bug in addbiblio.tmpl or Internet Explorer, but either way the above change corrects the problem.
OK, IE is right : "window.open(url,name,features,replace) name : an optional string of alphanumeric and underscore characters that specifies..." Once again, Mozilla don't bother with spaces, IE yes. I'll fix it immediatly in cvs. -- Paul POULAIN Consultant indépendant en logiciels libres responsable francophone de koha (SIGB libre http://www.koha-fr.org)
participants (2)
-
paul POULAIN -
Tim Stevens