Re: [Koha] Typos in Koha database description (Table "borrowers")
Hi Michael, The typos come from installer/data/mysql/kohastructure.sql The typos can be found in current master as well. Best way to fix the typos is to file a bug on https://bugs.koha-community.org/bugzilla3/ and then to attach a patch. Kind regards Marc Véron Am 27.05.2017 um 15:47 schrieb Michael Kuhn:
Hi
Recently I have found some typos in the SchemaSpy description of table "borrowers". * http://schema.koha-community.org/16_11/tables/borrowers.html
1. In the comment for field "debarred" (YYY-MM-DD) should by replaced by (YYYY-MM-DD)
2. In the comment for field "smsalertnumber" SNS should be replaced by SMS
3. In the comments of fields "contactname", "contacttitle", "guarantorid", "relationship" the term "guarentor" is used, but it should be "guarantor".
4. The comment for field "password" reads "patron/borrower's encrypted password". I think it could be mkore explicit by writing "patron/borrower's MD5 encrypted password".
Where can I correct these typos?
Best wishes: Michael
Hi Marc
The typos come from installer/data/mysql/kohastructure.sql
The typos can be found in current master as well.
Best way to fix the typos is to file a bug on https://bugs.koha-community.org/bugzilla3/ and then to attach a patch.
I have filed bugs before but until now I have never attached a patch. Is there a description somewhere what exactly to do when attaching a patch and especially how to create a patch? Best wishes: Michael -- Geschäftsführer · Diplombibliothekar BBS, Informatiker eidg. Fachausweis Admin Kuhn GmbH · Pappelstrasse 20 · 4123 Allschwil · Schweiz T 0041 (0)61 261 55 61 · E mik@adminkuhn.ch · W www.adminkuhn.ch
Hi Michael Have a look at devbox that provides a VM with pre-installed Koha for development purposes: https://github.com/digibib/kohadevbox/blob/master/README.md (I did not yet test it because I have an own VM for developing). You find there information and links related to working on patches and useful links to Koha documentation for developers as well. If you encounter problems or have questions about devbox it is a good idea to ask on IRC. Kind regards Marc Am 29.05.2017 um 10:14 schrieb Michael Kuhn:
Hi Marc
The typos come from installer/data/mysql/kohastructure.sql
The typos can be found in current master as well.
Best way to fix the typos is to file a bug on https://bugs.koha-community.org/bugzilla3/ and then to attach a patch.
I have filed bugs before but until now I have never attached a patch.
Is there a description somewhere what exactly to do when attaching a patch and especially how to create a patch?
Best wishes: Michael
Hi Marc
Have a look at devbox that provides a VM with pre-installed Koha for development purposes:
https://github.com/digibib/kohadevbox/blob/master/README.md (I did not yet test it because I have an own VM for developing).
You find there information and links related to working on patches and useful links to Koha documentation for developers as well.
OK, I already suspected this won't be a matter of 5 minutes and there is no easy way to follow. At the moment I don't have no time to install the current kohadevbox, relearn kohadevbox, install git, learn git etc. etc. so I will postpone this matter to some day in the future. Of course this process is quite scaring when I just want to correct some typos... But thanks anyway for confirming my apprehensions ;-) Best wishes: Michael -- Geschäftsführer · Diplombibliothekar BBS, Informatiker eidg. Fachausweis Admin Kuhn GmbH · Pappelstrasse 20 · 4123 Allschwil · Schweiz T 0041 (0)61 261 55 61 · E mik@adminkuhn.ch · W www.adminkuhn.ch
Hi Michael Maybe you can file a bug with the description of the typos? Kind regards Marc Am 29.05.2017 um 11:50 schrieb Michael Kuhn:
Hi Marc
Have a look at devbox that provides a VM with pre-installed Koha for development purposes:
https://github.com/digibib/kohadevbox/blob/master/README.md (I did not yet test it because I have an own VM for developing).
You find there information and links related to working on patches and useful links to Koha documentation for developers as well.
OK, I already suspected this won't be a matter of 5 minutes and there is no easy way to follow. At the moment I don't have no time to install the current kohadevbox, relearn kohadevbox, install git, learn git etc. etc. so I will postpone this matter to some day in the future. Of course this process is quite scaring when I just want to correct some typos...
But thanks anyway for confirming my apprehensions ;-)
Best wishes: Michael
Hi Marc
Maybe you can file a bug with the description of the typos?
Yes, I have just filed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18690 Best wishes: Michael -- Geschäftsführer · Diplombibliothekar BBS, Informatiker eidg. Fachausweis Admin Kuhn GmbH · Pappelstrasse 20 · 4123 Allschwil · Schweiz T 0041 (0)61 261 55 61 · E mik@adminkuhn.ch · W www.adminkuhn.ch
participants (2)
-
Marc Véron -
Michael Kuhn