Dear all We have just upgraded a koha from 3.16 (packages) to 16.11 and we're facing problems in aquisitions migration data. We have identified at least two types of issues... 1. Not all orders are shown in the module (they're al llinked to the records, then all the info is in mysql) for example when we search all orders we find just some of them, not all... 2. In funds, there are differences between the old and the new budgest...there is a 4% difference (I guess some fail with tax calculation) We have just now to dig on it.. but I wish to ask If anybody else has faced a similiar situation and have some tips or clue... if not we will share our experience. Kindest Regards Hugo -- *Hugo Agud - Orex Digital * *www.orex.es <http://www.orex.es>* <http://www.orex.es/> [image: www.orex.es/koha] <http://www.orex.es/koha> [image: www.orex.es/vufind] <http://www.orex.es/vufind> <http://www.orex.es/omeka> Director Calle Sant Joaquin,117, 2º-3ª · 08922 Santa Coloma de Gramanet - Tel: 933 856 138 hagud@orex.es · http://www.orex.es/ No imprima este mensaje a no ser que sea necesario. Una tonelada de papel implica la tala de 15 árboles y el consumo de 250.000 litros de agua. Aviso de confidencialidad Este mensaje contiene información que puede ser CONFIDENCIAL y/o de USO RESTRINGIDO. Si usted no es el receptor deseado del mensaje (ni está autorizado a recibirlo por el remitente), no está autorizado a copiar, reenviar o divulgar el mensaje o su contenido. Si ha recibido este mensaje por error, por favor, notifíquenoslo inmediatamente y bórrelo de su sistema.
Hi Hugo, A big work has been done in price calculation in 16.11, see bug 13321 and related. It certainly comes from these patches. I guess you can see differences in orders as well? If you find one, would you be able to give us the vendor and order tax configuration as well as the prices and quantity columns? Regards, Jonathan On Tue, 18 Apr 2017 at 07:05 Hugo Agud <hagud@orex.es> wrote:
Dear all
We have just upgraded a koha from 3.16 (packages) to 16.11 and we're facing problems in aquisitions migration data.
We have identified at least two types of issues...
1. Not all orders are shown in the module (they're al llinked to the records, then all the info is in mysql) for example when we search all orders we find just some of them, not all...
2. In funds, there are differences between the old and the new budgest...there is a 4% difference (I guess some fail with tax calculation)
We have just now to dig on it.. but I wish to ask If anybody else has faced a similiar situation and have some tips or clue... if not we will share our experience.
Kindest Regards Hugo
--
*Hugo Agud - Orex Digital *
*www.orex.es <http://www.orex.es>*
<http://www.orex.es/> [image: www.orex.es/koha] < http://www.orex.es/koha> [image: www.orex.es/vufind] <http://www.orex.es/vufind> <http://www.orex.es/omeka>
Director
Calle Sant Joaquin,117, 2º-3ª · 08922 Santa Coloma de Gramanet - Tel: 933 856 138 hagud@orex.es · http://www.orex.es/
No imprima este mensaje a no ser que sea necesario. Una tonelada de papel implica la tala de 15 árboles y el consumo de 250.000 litros de agua.
Aviso de confidencialidad Este mensaje contiene información que puede ser CONFIDENCIAL y/o de USO RESTRINGIDO. Si usted no es el receptor deseado del mensaje (ni está autorizado a recibirlo por el remitente), no está autorizado a copiar, reenviar o divulgar el mensaje o su contenido. Si ha recibido este mensaje por error, por favor, notifíquenoslo inmediatamente y bórrelo de su sistema. _______________________________________________ Koha mailing list http://koha-community.org Koha@lists.katipo.co.nz https://lists.katipo.co.nz/mailman/listinfo/koha
Hey Jonathan, Hey Hugo, we also have trouble in 16.11 with tax calculation : mysql> select unitprice_tax_excluded, unitprice_tax_included from aqorders join aqinvoices on aqinvoices.invoiceid = aqorders.invoiceid where aqinvoices.invoiceid = 2674 limit 10; +------------------------+------------------------+ | unitprice_tax_excluded | unitprice_tax_included | +------------------------+------------------------+ | 80.400000 | 80.400000 | | 32.760000 | 32.760000 | | 110.700000 | 110.700000 | | 87.410000 | 87.410000 | | 23.290000 | 23.290000 | | 127.320000 | 127.320000 | | 28.940000 | 28.940000 | | 72.240000 | 72.240000 | | 205.670000 | 205.670000 | | 18.590000 | 18.590000 | +------------------------+------------------------+ 10 rows in set (0.00 sec) We had a lot of errors while upgrading we unfortunately didn't pay attention to: Use of uninitialized value in multiplication (*) at ./installer/data/mysql/updatedatabase.pl line 13614. [A LOT MORE OF THE SAME THING] Use of uninitialized value in multiplication (*) at ./installer/data/mysql/updatedatabase.pl line 13619. Upgrade to 16.06.00.043 done (Bug 13323 - Change the tax rate on receiving) I'm going to investigate this, if someone as good ideas I'm eager to hear from them :).
Sorry, it seems to be a problem with our conf, we avec a 0 taxes rate, since we buy from the whole world. 2017-04-19 17:16 GMT+02:00 Nicolas Legrand <nicolas.legrand@bulac.fr>:
Hey Jonathan, Hey Hugo,
we also have trouble in 16.11 with tax calculation :
mysql> select unitprice_tax_excluded, unitprice_tax_included from aqorders join aqinvoices on aqinvoices.invoiceid = aqorders.invoiceid where aqinvoices.invoiceid = 2674 limit 10; +------------------------+------------------------+ | unitprice_tax_excluded | unitprice_tax_included | +------------------------+------------------------+ | 80.400000 | 80.400000 | | 32.760000 | 32.760000 | | 110.700000 | 110.700000 | | 87.410000 | 87.410000 | | 23.290000 | 23.290000 | | 127.320000 | 127.320000 | | 28.940000 | 28.940000 | | 72.240000 | 72.240000 | | 205.670000 | 205.670000 | | 18.590000 | 18.590000 | +------------------------+------------------------+ 10 rows in set (0.00 sec)
We had a lot of errors while upgrading we unfortunately didn't pay attention to:
Use of uninitialized value in multiplication (*) at ./installer/data/mysql/updatedatabase.pl line 13614. [A LOT MORE OF THE SAME THING] Use of uninitialized value in multiplication (*) at ./installer/data/mysql/updatedatabase.pl line 13619. Upgrade to 16.06.00.043 done (Bug 13323 - Change the tax rate on receiving)
I'm going to investigate this, if someone as good ideas I'm eager to hear from them :).
-- Nicolas Legrand Administration technique et développements du système de gestion de la bibliothèque Bibliothèque universitaire des langues et civilisations 65 rue des Grands Moulins F-75013 PARIS T +33 1 81 69 18 22 www.bulac.fr
Nicolas, what you describe can be ok, if the tax rate is 0. You need to provide ALL the price values from aqorders (quantity, listprice, unitprice, unitprice_tax_excluded, unitprice_tax_included, quantityreceived, rrp, rrp_tax_excluded, rrp_tax_included, ecost, ecost_tax_excluded, ecost_tax_included, tax_rate_bak, tax_rate_on_ordering, tax_rate_on_receiving, tax_value_bak, tax_value_on_ordering, tax_value_on_receiving, discount, uncertainprice). On Wed, 19 Apr 2017 at 12:16 Nicolas Legrand <nicolas.legrand@bulac.fr> wrote:
Hey Jonathan, Hey Hugo,
we also have trouble in 16.11 with tax calculation :
mysql> select unitprice_tax_excluded, unitprice_tax_included from aqorders join aqinvoices on aqinvoices.invoiceid = aqorders.invoiceid where aqinvoices.invoiceid = 2674 limit 10; +------------------------+------------------------+ | unitprice_tax_excluded | unitprice_tax_included | +------------------------+------------------------+ | 80.400000 | 80.400000 | | 32.760000 | 32.760000 | | 110.700000 | 110.700000 | | 87.410000 | 87.410000 | | 23.290000 | 23.290000 | | 127.320000 | 127.320000 | | 28.940000 | 28.940000 | | 72.240000 | 72.240000 | | 205.670000 | 205.670000 | | 18.590000 | 18.590000 | +------------------------+------------------------+ 10 rows in set (0.00 sec)
We had a lot of errors while upgrading we unfortunately didn't pay attention to:
Use of uninitialized value in multiplication (*) at ./installer/data/mysql/updatedatabase.pl line 13614. [A LOT MORE OF THE SAME THING] Use of uninitialized value in multiplication (*) at ./installer/data/mysql/updatedatabase.pl line 13619. Upgrade to 16.06.00.043 done (Bug 13323 - Change the tax rate on receiving)
I'm going to investigate this, if someone as good ideas I'm eager to hear from them :).
I think I now have something in invoice.pl : $line->{total_tax_excluded} = Koha::Number::Price->new( $line->{unitprice_tax_excluded} * $line->{quantity} )->format; $line->{total_tax_included} = Koha::Number::Price->new( $line->{unitprice_tax_included} * $line->{quantity} )->format; Format yield a string, with a comma for french format and not a dot. The problem is: we're doing calculation with the formatted value, for example : $total_tax_excluded += $$line{total_tax_excluded}; With a string with comma, it rounds the result: $ perl -E 'say "2,2" + 2' 4 $ perl -E 'say "2.2" + 2' 4.2 2017-04-19 17:43 GMT+02:00 Jonathan Druart <jonathan.druart@bugs.koha-community.org>:
Nicolas, what you describe can be ok, if the tax rate is 0. You need to provide ALL the price values from aqorders (quantity, listprice, unitprice, unitprice_tax_excluded, unitprice_tax_included, quantityreceived, rrp, rrp_tax_excluded, rrp_tax_included, ecost, ecost_tax_excluded, ecost_tax_included, tax_rate_bak, tax_rate_on_ordering, tax_rate_on_receiving, tax_value_bak, tax_value_on_ordering, tax_value_on_receiving, discount, uncertainprice).
On Wed, 19 Apr 2017 at 12:16 Nicolas Legrand <nicolas.legrand@bulac.fr> wrote:
Hey Jonathan, Hey Hugo,
we also have trouble in 16.11 with tax calculation :
mysql> select unitprice_tax_excluded, unitprice_tax_included from aqorders join aqinvoices on aqinvoices.invoiceid = aqorders.invoiceid where aqinvoices.invoiceid = 2674 limit 10; +------------------------+------------------------+ | unitprice_tax_excluded | unitprice_tax_included | +------------------------+------------------------+ | 80.400000 | 80.400000 | | 32.760000 | 32.760000 | | 110.700000 | 110.700000 | | 87.410000 | 87.410000 | | 23.290000 | 23.290000 | | 127.320000 | 127.320000 | | 28.940000 | 28.940000 | | 72.240000 | 72.240000 | | 205.670000 | 205.670000 | | 18.590000 | 18.590000 | +------------------------+------------------------+ 10 rows in set (0.00 sec)
We had a lot of errors while upgrading we unfortunately didn't pay attention to:
Use of uninitialized value in multiplication (*) at ./installer/data/mysql/updatedatabase.pl line 13614. [A LOT MORE OF THE SAME THING] Use of uninitialized value in multiplication (*) at ./installer/data/mysql/updatedatabase.pl line 13619. Upgrade to 16.06.00.043 done (Bug 13323 - Change the tax rate on receiving)
I'm going to investigate this, if someone as good ideas I'm eager to hear from them :).
_______________________________________________ Koha mailing list http://koha-community.org Koha@lists.katipo.co.nz https://lists.katipo.co.nz/mailman/listinfo/koha
-- Nicolas Legrand Administration technique et développements du système de gestion de la bibliothèque Bibliothèque universitaire des langues et civilisations 65 rue des Grands Moulins F-75013 PARIS T +33 1 81 69 18 22 www.bulac.fr
Yes indeed, the formatting should be done template side. They are the only 2 occurrences of this kind apparently. Did you open a bug report? On Thu, 20 Apr 2017 at 05:59 Nicolas Legrand <nicolas.legrand@bulac.fr> wrote:
I think I now have something in invoice.pl :
$line->{total_tax_excluded} = Koha::Number::Price->new( $line->{unitprice_tax_excluded} * $line->{quantity} )->format; $line->{total_tax_included} = Koha::Number::Price->new( $line->{unitprice_tax_included} * $line->{quantity} )->format;
Format yield a string, with a comma for french format and not a dot. The problem is: we're doing calculation with the formatted value, for example :
$total_tax_excluded += $$line{total_tax_excluded};
With a string with comma, it rounds the result:
$ perl -E 'say "2,2" + 2' 4 $ perl -E 'say "2.2" + 2' 4.2
2017-04-19 17:43 GMT+02:00 Jonathan Druart <jonathan.druart@bugs.koha-community.org>:
Nicolas, what you describe can be ok, if the tax rate is 0. You need to provide ALL the price values from aqorders (quantity, listprice, unitprice, unitprice_tax_excluded, unitprice_tax_included, quantityreceived, rrp, rrp_tax_excluded, rrp_tax_included, ecost, ecost_tax_excluded, ecost_tax_included, tax_rate_bak, tax_rate_on_ordering, tax_rate_on_receiving, tax_value_bak, tax_value_on_ordering, tax_value_on_receiving, discount, uncertainprice).
On Wed, 19 Apr 2017 at 12:16 Nicolas Legrand <nicolas.legrand@bulac.fr> wrote:
Hey Jonathan, Hey Hugo,
we also have trouble in 16.11 with tax calculation :
mysql> select unitprice_tax_excluded, unitprice_tax_included from aqorders join aqinvoices on aqinvoices.invoiceid = aqorders.invoiceid where aqinvoices.invoiceid = 2674 limit 10; +------------------------+------------------------+ | unitprice_tax_excluded | unitprice_tax_included | +------------------------+------------------------+ | 80.400000 | 80.400000 | | 32.760000 | 32.760000 | | 110.700000 | 110.700000 | | 87.410000 | 87.410000 | | 23.290000 | 23.290000 | | 127.320000 | 127.320000 | | 28.940000 | 28.940000 | | 72.240000 | 72.240000 | | 205.670000 | 205.670000 | | 18.590000 | 18.590000 | +------------------------+------------------------+ 10 rows in set (0.00 sec)
We had a lot of errors while upgrading we unfortunately didn't pay attention to:
Use of uninitialized value in multiplication (*) at ./installer/data/mysql/updatedatabase.pl line 13614. [A LOT MORE OF THE SAME THING] Use of uninitialized value in multiplication (*) at ./installer/data/mysql/updatedatabase.pl line 13619. Upgrade to 16.06.00.043 done (Bug 13323 - Change the tax rate on receiving)
I'm going to investigate this, if someone as good ideas I'm eager to hear from them :).
_______________________________________________ Koha mailing list http://koha-community.org Koha@lists.katipo.co.nz https://lists.katipo.co.nz/mailman/listinfo/koha
--
Nicolas Legrand Administration technique et développements du système de gestion de la bibliothèque
Bibliothèque universitaire des langues et civilisations
65 rue des Grands Moulins F-75013 PARIS T +33 1 81 69 18 22 <01%2081%2069%2018%2022> www.bulac.fr
Nick did open one, there is a patch to signoff, see bug 18471. On Thu, 20 Apr 2017 at 11:38 Jonathan Druart < jonathan.druart@bugs.koha-community.org> wrote:
Yes indeed, the formatting should be done template side. They are the only 2 occurrences of this kind apparently. Did you open a bug report?
On Thu, 20 Apr 2017 at 05:59 Nicolas Legrand <nicolas.legrand@bulac.fr> wrote:
I think I now have something in invoice.pl :
$line->{total_tax_excluded} = Koha::Number::Price->new( $line->{unitprice_tax_excluded} * $line->{quantity} )->format; $line->{total_tax_included} = Koha::Number::Price->new( $line->{unitprice_tax_included} * $line->{quantity} )->format;
Format yield a string, with a comma for french format and not a dot. The problem is: we're doing calculation with the formatted value, for example :
$total_tax_excluded += $$line{total_tax_excluded};
With a string with comma, it rounds the result:
$ perl -E 'say "2,2" + 2' 4 $ perl -E 'say "2.2" + 2' 4.2
2017-04-19 17:43 GMT+02:00 Jonathan Druart <jonathan.druart@bugs.koha-community.org>:
Nicolas, what you describe can be ok, if the tax rate is 0. You need to provide ALL the price values from aqorders (quantity, listprice, unitprice, unitprice_tax_excluded, unitprice_tax_included, quantityreceived, rrp, rrp_tax_excluded, rrp_tax_included, ecost, ecost_tax_excluded, ecost_tax_included, tax_rate_bak, tax_rate_on_ordering, tax_rate_on_receiving, tax_value_bak, tax_value_on_ordering, tax_value_on_receiving, discount, uncertainprice).
On Wed, 19 Apr 2017 at 12:16 Nicolas Legrand <nicolas.legrand@bulac.fr> wrote:
Hey Jonathan, Hey Hugo,
we also have trouble in 16.11 with tax calculation :
mysql> select unitprice_tax_excluded, unitprice_tax_included from aqorders join aqinvoices on aqinvoices.invoiceid = aqorders.invoiceid where aqinvoices.invoiceid = 2674 limit 10; +------------------------+------------------------+ | unitprice_tax_excluded | unitprice_tax_included | +------------------------+------------------------+ | 80.400000 | 80.400000 | | 32.760000 | 32.760000 | | 110.700000 | 110.700000 | | 87.410000 | 87.410000 | | 23.290000 | 23.290000 | | 127.320000 | 127.320000 | | 28.940000 | 28.940000 | | 72.240000 | 72.240000 | | 205.670000 | 205.670000 | | 18.590000 | 18.590000 | +------------------------+------------------------+ 10 rows in set (0.00 sec)
We had a lot of errors while upgrading we unfortunately didn't pay attention to:
Use of uninitialized value in multiplication (*) at ./installer/data/mysql/updatedatabase.pl line 13614. [A LOT MORE OF THE SAME THING] Use of uninitialized value in multiplication (*) at ./installer/data/mysql/updatedatabase.pl line 13619. Upgrade to 16.06.00.043 done (Bug 13323 - Change the tax rate on receiving)
I'm going to investigate this, if someone as good ideas I'm eager to hear from them :).
_______________________________________________ Koha mailing list http://koha-community.org Koha@lists.katipo.co.nz https://lists.katipo.co.nz/mailman/listinfo/koha
--
Nicolas Legrand Administration technique et développements du système de gestion de la bibliothèque
Bibliothèque universitaire des langues et civilisations
65 rue des Grands Moulins F-75013 PARIS T +33 1 81 69 18 22 <01%2081%2069%2018%2022> www.bulac.fr
participants (3)
-
Hugo Agud -
Jonathan Druart -
Nicolas Legrand