Koha Acquisition Module - problems when modifying the price, conversion rate and currency while receving the order
Hi, We at The Institute of Mathematical Sciences, Chennai, India have been successfully been using all the modules of Koha including serials module. We have recently upgraded to the version 16.11.05 from 3.22 without any issues. We request Koha developers to kindly look at the following issues with regard to Acquisition module: 1. Koha->Acquisitions->Vendor->Receive shipment 2. Invoice details are filled in -> Next 3. Under receipt summary, select the basket and receive the item If no changes are required like price, currency and conversion rates etc, then no problem and finish the receiving. But, when we need to change the price or currency or conversion rates, then option available to effect the change is only through editing the orderline number (by clicking the orderline number) in the receipt summary page. In Koha 3.22: While editing the order line number, the URL passes two parameters viz.1. ordernumber and 2.booksellerid as shown below: http://library.imsc.res.in:8001/cgi-bin/koha/acqui/neworderempty.pl?ordernumber=4&booksellerid=1 As you may notice, the parameters passed in the URL hold good for books acquisition. But for the serials, subscriptionid is another important parameter to be passed in the URL to identify the particular serial subscription. This is not provided in Version 3.22. We manually pass this subscriptionid parameter in the URL as below to acheive the functionality: http://10.96.68.205:8001/cgi-bin/koha/acqui/neworderempty.pl?ordernumber=4&booksellerid=1&subscriptionid=4 In Koha 16.11.05 In 16.11.05, the subscriptionid as a parameter is also being passed alongwith ordernumber, booksellerid in the URL while editing the orderline for change of price, currency and conversion rate when receiving the item as follows: For Serials: http://10.96.68.172:8001/cgi-bin/koha/acqui/neworderempty.pl?ordernumber=795&booksellerid=37&subscriptionid=421 This works without any problem (It is being fixed in the 16.11.05 which was a bug in 3.22) For Books: http://10.96.68.172:8001/cgi-bin/koha/acqui/neworderempty.pl?ordernumber=796&booksellerid=37&subscriptionid= As you may notice in the above URL, there is no subscriptionid value as it is a book, hence the following error occured: Software error: Cannot insert order: Mandatory parameter basketno is missing at /usr/share/koha/intranet/cgi-bin/acqui/addorder.pl line 289. We have to manually remove the parameter &subscriptionid=, then only are we able to process the invoice and receive the book. THIS IS A BUG. Many of you who use acquistion for both books and Serials must have come across the above problems and request the Koha Developers community to kindly spare some to fix these problems at the earliest. Looking forward to your help! Thanks and Regards, Paul Pandian and Maruthu Pandiyan Institute of Mathematical Sciences CIT Campus, Taramani Chennai 600113, India
Hi Paul, Il 18/07/2017 07:58, Paul Pandian ha scritto:
We request Koha developers to kindly look at the following issues with regard to Acquisition module:
the first problem on your request is that you are working on 16.11.05 Now Koha is on 17.05.1 and on 16.11.09 As first check we need to know if bug is still present. To do this, you can use a sandbox. See here: https://wiki.koha-community.org/wiki/Sandboxes You can go here: http://kohastaffsandbox.ptfs-europe.co.uk/ with login 'test' and password 'test'. This sandbox is ready to test your problem. So, go to http://kohastaffsandbox.ptfs-europe.co.uk/, test the problem and save screenshoots of operations that you do. After the check, write again here. Bye Zeno Tajoli -- Zeno Tajoli /SVILUPPO PRODOTTI CINECA/ - Automazione Biblioteche Email: z.tajoli@cineca.it Fax: 051/6132198 *CINECA* Consorzio Interuniversitario - Sede operativa di Segrate (MI)
Dear Tajoli, Many thanks. We tried your sandbox (Koha 17.06.00.003) with acqusition module and found that this particular functionality (change of price, currency and conversion rates while receiving the order) remains the VERY same as that of Koha 3.22 as given below in the example: While editing the order line number, the URL passes two parameters viz.1. ordernumber and 2.booksellerid as shown below: http://library.imsc.res.in:8001/cgi-bin/koha/acqui/neworderempty.pl?ordernumber=4&booksellerid=1 As you may notice, the parameters passed in the URL hold good for books acquisition. But for the serials, subscriptionid is another important parameter to be passed in the URL to identify the particular serial subscription. This is not provided even in the Version 17.06. We have to manually pass this subscriptionid parameter in the URL as below to acheive the functionality: http://library.imsc.res.in:8001/cgi-bin/koha/acqui/neworderempty.pl?ordernumber=4&booksellerid=1&subscriptionid=4 So, what should happen is that when passing the parameters in the URL while editing the orderline during the receipt of the order: For every order number, system should check for subscriptionid value and should include the subscriptionid parameter in the URL only when subscriptionid value is present. In otherwords, if the subscriptionid value is present, then URL will have subscriptionid parameter with values (&subscriptionid=4 for example). If subscriptionid value is not present for the order number, then this subscriptionid parameter should NOT be passed at all in the URL. We think this should fix this problem. We have tested manually. Kindly look at the codes and do the needful to effect the above functionality. With kind regards, Paul Pandian and Maruthu Pandiyan ----- ========================================================================= Scientific Officer (Library) | The Institute of Mathematical Sciences | (An Autonomous Institute of Department | of Atomic Energy, Goverment of India) | CIT Campus, Taramani | Chennai 600 113, Tamilnadu |Phone: +91-44-2254 3383(D) | +91-44-2254 3100(EPABX) India |Fax: +91-44-2254 1586 |E-mail: pandian@imsc.res.in Website https://library.imsc.res.in ========================================================================= On Tue, 18 Jul 2017, Tajoli Zeno wrote:
Hi Paul,
Il 18/07/2017 07:58, Paul Pandian ha scritto:
We request Koha developers to kindly look at the following issues with regard to Acquisition module:
the first problem on your request is that you are working on 16.11.05 Now Koha is on 17.05.1 and on 16.11.09 As first check we need to know if bug is still present. To do this, you can use a sandbox. See here: https://wiki.koha-community.org/wiki/Sandboxes
You can go here: http://kohastaffsandbox.ptfs-europe.co.uk/ with login 'test' and password 'test'. This sandbox is ready to test your problem.
So, go to http://kohastaffsandbox.ptfs-europe.co.uk/, test the problem and save screenshoots of operations that you do.
After the check, write again here.
Bye Zeno Tajoli
-- Zeno Tajoli /SVILUPPO PRODOTTI CINECA/ - Automazione Biblioteche Email: z.tajoli@cineca.it Fax: 051/6132198 *CINECA* Consorzio Interuniversitario - Sede operativa di Segrate (MI)
Hi Paul and all, I confirm that there is a bug about this topic. I create a bug in bugzilla here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19030 I can't write the code to fix it. I suggest to ask for a quote to fix it to many dirm that work on Koha, https://koha-community.org/support/paid-support/ Bye Zeno Tajoli Il 20/07/2017 07:48, Paul Pandian ha scritto:
Dear Tajoli,
Many thanks. We tried your sandbox (Koha 17.06.00.003) with acqusition module and found that this particular functionality (change of price, currency and conversion rates while receiving the order) remains the VERY same as that of Koha 3.22 as given below in the example:
While editing the order line number, the URL passes two parameters viz.1. ordernumber and 2.booksellerid as shown below:
http://library.imsc.res.in:8001/cgi-bin/koha/acqui/neworderempty.pl?ordernumber=4&booksellerid=1
As you may notice, the parameters passed in the URL hold good for books acquisition. But for the serials, subscriptionid is another important parameter to be passed in the URL to identify the particular serial subscription. This is not provided even in the Version 17.06. We have to manually pass this subscriptionid parameter in the URL as below to acheive the functionality:
So, what should happen is that when passing the parameters in the URL while editing the orderline during the receipt of the order:
For every order number, system should check for subscriptionid value and should include the subscriptionid parameter in the URL only when subscriptionid value is present. In otherwords, if the subscriptionid value is present, then URL will have subscriptionid parameter with values (&subscriptionid=4 for example). If subscriptionid value is not present for the order number, then this subscriptionid parameter should NOT be passed at all in the URL. We think this should fix this problem. We have tested manually.
Kindly look at the codes and do the needful to effect the above functionality.
With kind regards,
Paul Pandian and Maruthu Pandiyan
----- ========================================================================= Scientific Officer (Library) | The Institute of Mathematical Sciences | (An Autonomous Institute of Department | of Atomic Energy, Goverment of India) | CIT Campus, Taramani | Chennai 600 113, Tamilnadu |Phone: +91-44-2254 3383(D) | +91-44-2254 3100(EPABX) India |Fax: +91-44-2254 1586 |E-mail: pandian@imsc.res.in Website https://library.imsc.res.in =========================================================================
On Tue, 18 Jul 2017, Tajoli Zeno wrote:
Hi Paul,
Il 18/07/2017 07:58, Paul Pandian ha scritto:
We request Koha developers to kindly look at the following issues with regard to Acquisition module:
the first problem on your request is that you are working on 16.11.05 Now Koha is on 17.05.1 and on 16.11.09 As first check we need to know if bug is still present. To do this, you can use a sandbox. See here: https://wiki.koha-community.org/wiki/Sandboxes
You can go here: http://kohastaffsandbox.ptfs-europe.co.uk/ with login 'test' and password 'test'. This sandbox is ready to test your problem.
So, go to http://kohastaffsandbox.ptfs-europe.co.uk/, test the problem and save screenshoots of operations that you do.
After the check, write again here.
Bye Zeno Tajoli
-- Zeno Tajoli /SVILUPPO PRODOTTI CINECA/ - Automazione Biblioteche Email: z.tajoli@cineca.it Fax: 051/6132198 *CINECA* Consorzio Interuniversitario - Sede operativa di Segrate (MI)
-- Zeno Tajoli /SVILUPPO PRODOTTI CINECA/ - Automazione Biblioteche Email: z.tajoli@cineca.it Fax: 051/6132198 *CINECA* Consorzio Interuniversitario - Sede operativa di Segrate (MI)
participants (2)
-
Paul Pandian -
Tajoli Zeno