On Wed, Nov 5, 2008 at 7:55 AM, Emrys Minnig <emrysminnig@varndean.co.uk> wrote:

Something that might be of interest to the development team...

I think there's a small oversight in C4/Amazon.pm. On line 101 it reads:

my $uri = "http://www.amazon.com/gp/reader/$isbn/ref=sib_dp_pt/002-7879865-0184864#read...";

This line ignores the locale settings (in my case UK) which the majority of times breaks the 'Search Inside' capability.

Good point Emrys. Can you file a bug in bugzilla (bugs.koha.org) and assign it to me? Thanks, Josh

Cheers!

-Emrys

_______________________________________________ Koha mailing list Koha@lists.katipo.co.nz http://lists.katipo.co.nz/mailman/listinfo/koha

-- Joshua Ferraro SUPPORT FOR OPEN-SOURCE SOFTWARE CEO migration, training, maintenance, support LibLime Featuring Koha Open-Source ILS jmf@liblime.com |Full Demos at http://liblime.com/koha |1(888)KohaILS

Emrys Minnig wrote:

Something that might be of interest to the development team... I think there's a small oversight in C4/Amazon.pm. On line 101 it reads:

my $uri = "http://www.amazon.com/gp/reader/$isbn/ref=sib_dp_pt/002-7879865-0184864#read...";

This line ignores the locale settings (in my case UK) which the majority of times breaks the 'Search Inside' capability.

Which raises another question: why is there a URL such as the above hard-coded in the software? This kind of data should be treated as data ... and stored in the configuration database. cheers rickw